157 Commits

Author SHA1 Message Date
Andrea Bondavalli
8f09eec36c Disabled use of valgrind memcheck during daemon regression tests 2020-06-04 09:23:59 -07:00
Andrea Bondavalli
371090e7b9 Changes to SessionManager class to handle notifications for source updates triggered when the PTP GMID clock changes or the driver sample rate changes.
SessionManager allows the registration of source update observers and delivers via callbacks the above notifications.
RTSP server modified to register to source update notifications and to send updates to clients via ANNOUNCE method.
2020-06-04 09:14:17 -07:00
Andrea Bondavalli
3a60c0492f Change to RTSP client to accept also an empty Content-Type.
In this case application/sdp is assumed.
2020-06-04 09:12:39 -07:00
Andrea Bondavalli
0367dc33a0 MDNS client changed to avoid that multiple Avahi resolvers try to resolve the same name and domain simultaneously 2020-06-04 09:09:57 -07:00
Andrea Bondavalli
e348400246 Improved robustness of RTSP client removal handling 2020-06-02 14:10:36 -07:00
Andrea Bondavalli
267b97cbe7 Fix: added removal of RTSP client session if RTSP client connection closes 2020-06-02 12:31:40 -07:00
Andrea Bondavalli
836cee03f1 Added mDNS sourceS update regression tests:
- added source_check_mdns_browser_update test to verify mDNS update notification for a single source
- added add_remove_check_mdns_browser_update_all test to verify mDNS update notifications for all 64 sources
- additional fixes and minor changes to the test suite
2020-06-02 11:05:38 -07:00
Andrea Bondavalli
e05253d444 Additional set of changes to complete support for mDNS sources update via RTSP ANNOUNCE method as described by Ravenna.
The following changes enable support for RTCP client persistent connections used to receive RTSP server ANNOUNCE messages. These in turn update the remote sources in the Browser.
- added new process static method to RtspClient class to receive and update source SDP files via DESCRIBE and ANNOUNCE methods. This method can handle persistent connections with the RTSP server and triggers an observer callback when a source SDP file is received or updated. A map is used to track all active RTSP clients.
- added new stop and stop_all static methods to RtspClient class respectively to stop a specific RTCP client and to stop all clients.
- modified MDNSClient class to call RtspClient::process method when a new Ravenna service is added and the RtspClient::stop method when a service is removed. The RtspClient::stop_all method is called when the daemon terminates.
- modified Browser class to receive and handle remote RTSP sources SDP file add and change notifications. This class receives the updates via the RtspClient observer callback
- updated documentation
2020-06-02 10:56:44 -07:00
Andrea Bondavalli
aeb4e8b0a0 Changed maximum number of concurrent RTSP server sessions to 128 (double the maximum number of allowed Sources) 2020-06-02 09:55:51 -07:00
Andrea Bondavalli
cd6a651014 Fix to header file 2020-06-01 12:02:40 -07:00
Andrea Bondavalli
85727ea02f RTSP server ignores responses to ANNOUNCE 2020-06-01 12:00:34 -07:00
Andrea Bondavalli
d41b67d006 Set of changes to add support for mDNS sources SDP update via RTSP ANNOUNCE method as described by Ravenna.
- modified SessionManager class to register and trigger observer callbacks when a new session is added or removed
- moved MDNSServer out of the SessionManager and added instantiation in the daemon main
- MDNSServer instance registers to SessionManager to receive source add & remove events and invokes appropiate Avahi client operation
- RTSPServer instance registers to SessionManager to receive source update events. In case of update It sends RTSP ANNOUNCE (with the new SDP) to the connected RTSP clients that previously requested (via DESCRIBE method) the SDP file for the specific source
- removed disconnetion timeout handling in RTSPServer. RTSPServer connections are now persistent
2020-05-28 20:47:38 +02:00
Andrea Bondavalli
07c2b35777 Various enhancements and fixes:
- fixed handling of Max samples per packet Source parameter in the WebUI and added computation of the real frame duration
- fixed max number of channels configurable for a Sink in the WebUI
- fixed tic_frame_size_at_1fs daemon parameter documentation
- changed daemon default sample_rate parameter to 48000 Hz
2020-05-07 20:07:19 +02:00
Andrea Bondavalli
9c4913f7e4
Update README.md 2020-05-02 21:47:01 +02:00
Andrea Bondavalli
745fa05d0b Improved handling of "tic_frame_size_at_1fs" daemon parameter, added the possibility to configure it with the WebUI and updated the documentation. 2020-05-02 20:20:21 +02:00
Andrea Bondavalli
37fa1de81b Minor changes 2020-05-02 11:39:51 +02:00
Andrea Bondavalli
4ccc2f526f Fix for issue Daemon fails to parse AVIO SDP file
- use correct delimiter ('=') and unsigned integer when extracing RTP timestamp offset from mediaclk:direct SDP audio attribute
 - use session connection information (c=) when audio specific connection information is missing
2020-04-27 21:15:37 +02:00
Andrea Bondavalli
9d714eb747 Minor changes 2020-04-24 10:59:19 -07:00
Andrea Bondavalli
0757318732 Fixed bug in SessionMange::get_source_id() method 2020-04-24 09:09:40 -07:00
Andrea Bondavalli
9d0e721e17 Added AM824 codec support to documentation 2020-04-24 09:07:26 -07:00
Andrea Bondavalli
29dcfba0bd Merge branch 'master' into codec_am824 2020-04-23 22:44:33 +02:00
Andrea Bondavalli
fdccd4f577 Removed unused functions from utils 2020-04-23 22:42:30 +02:00
Andrea Bondavalli
b35b36c91e Merge branch 'master' into codec_am824 2020-04-23 12:11:26 -07:00
Andrea Bondavalli
0dbfe78a10 - Added support for mDNS/RTSP sources advertisement compatible with Ravenna standard.
- mDNS advertisement for all local Sources is implemented by mdns_server.[cpp,hpp] and based on Linux Avahi.
  - RTSP server implementation supports DESCRIBE method to return SDP of local Sources and supports persistent connection but doesn't provide service updates via UPDATE method.
- Modified RTSP client to browse for _ravenna_session subtype of _rtsp._tcp services only.
- Modified SAP and mDNS discovery to avoid returning local Sources advertised by the daemon.
- Added "rtsp_port" and "node_id" config parameters.
  - rtsp_port is a read/write parameter that contains the port of the RTSP server.
  - node_id is a read only parameter that contains the unique daemon identifier used in mDNS and SAP sources announcements.
- Modified session manager to check that every Source and Sink created by the user has a unique name.
- Modified WebUI to visualize node_id and to visualize and edit rtsp_port parameters in Config tab.
- Extended regression test to verify proper behaviour of mDNS/RTSP sources advertisement and discovery.
- Modified REST API to browse remote sources to allow browsing of SAP, mDNS and all sources via HTTP GET /api/browse/sources/[all|mdns|sap].
- Amended daemon documentation.
2020-04-23 11:45:58 -07:00
Andrea Bondavalli
1d2ea0875c Added support for AM824 codec for testing
- added patch to ravenna-alsa-lkm module to support AM824 codec and associated conversion functions
- added support for AM824 codec to daemon and in WebUI
- modifed demo to test 8 channels of AM824 with 6 samples per packet @ 48Khz (125us x packet)
2020-04-10 13:04:44 -07:00
Andrea Bondavalli
e9dd44fdb4 Minor changes 2020-04-10 13:01:36 -07:00
Andrea Bondavalli
9898c9fac0 Set of enhancements and fixes to the daemon browser:
- browser stores the RTSP sources discovered via mDNS by name and domain
- domain field added to JSON Remote Source params
- removed trailing CR/LF to the end of SAP source name
2020-04-08 11:24:10 -07:00
Andrea Bondavalli
0f8b9e714e Revised Avahi client integration in mDNS client:
- aligned state handling with avahi-browse tool: browser is started in client callback
- browsing is limited to IPv4 services discovered on the specific daemon network interface only
Additional minor changes.
2020-04-03 09:55:01 -07:00
Andrea Bondavalli
85c36c3fd6 fix: mdns_enabled parameter encoded as JSON boolean instead of JSON string 2020-04-02 19:50:35 +02:00
Andrea Bondavalli
92768454f4 Increased HTTP client read timeout in session manager and in regression tests.
This fixes regression tests execution on slow hosts.
2020-04-01 17:39:48 +02:00
Andrea Bondavalli
bf8a4c56da Fixed handling of IGMP join and leave for the multicast RTP sessions.
The IGMP handling was broken in case the RTP multicast address of a stream was updated.
2020-03-30 18:58:07 +02:00
Andrea Bondavalli
3947b77d7c Fixed error check of rtp_mcast_base and sap_mcast_addr parameters.
The problem was preventing the possibility to change the values from the defaults of these two parameters.
2020-03-30 18:55:10 +02:00
Andrea Bondavalli
5deb6c1927 Added to the daemon the support for Multicast DNS (using Linux Avahi) to allow discovery of remote audio sources and of RTSP for SDP transfer.
Added to the WebUI the possibility to directly select a remote source SDP file for a Sink.

New files:
daemon/mdns_client.hpp,cpp -> mDNS client implementation using Avahi client library
daemon/rtsp_client.hpp,cpp -> RTSP client implementation used to transfer SDP file
daemon/utils.cpp -> used for common utility functions
.clang-format -> added clang-format configuration file

Modified files:
daemon/CMakeList.txt -> added support for Avahi and option WITH_AVAHI=[yes/no] to compile the daemon with or without Avahi mDNS support
daemon/config.hpp,cpp -> added configuration option mdns_enabled to enable or disable mDNS discovery at runtime
daemon/json.cpp -> extended JSON config with mdns_enabled option
daemon/browser.hpp,cpp -> added support for mDNS client to the browser
daemon/session_manager.cpp -> added support for RTSP protocol to Source URL field and fixed issue with SDP file parsing
webui/RemoteSources.js -> added visualization of mDNS remote sources
webui/SinkEdit.js -> added the possibility to directly select a remote source SDP file for a Sink
webui/SourceInfo.js -> added visualization of protocol source (SAP, mDNS or local) for a source
ubuntu-packages.sh -> added libavahi-client-dev to the list of required packages
build.sh -> added WITH_AVAHI=yes option when invoking CMake
README.md -> added notes about mDNS support via Avahi
daemon/README.md -> added notes about mDNS support via Avahi, support for RTSP protocol in source and new mdns_enabled config param

Additional minor changes to remaining files.
2020-03-29 19:41:56 +02:00
Andrea Bondavalli
596500b130 Minor changes 2020-03-20 22:58:21 +01:00
Andrea Bondavalli
dff3ab3cba Multiple fixes:
- fixed destination MAC address set when adding a source and a sink according to IANA specs
- fixed retrieval of network interface MAC address
- added <list> inclusion to header files using std::list
- fixed regression test suite
- additional minor changes
2020-03-20 18:58:08 +01:00
Andrea Bondavalli
a70505989f Minor changes 2020-03-06 23:11:54 +01:00
Andrea Bondavalli
27bee43c20 Fixes to documentation 2020-03-06 11:16:39 -08:00
Andrea Bondavalli
d99bf3ed4a Added SAP browser functionalities to the daemon and the WebUI
- added "sap_mcast_addr" parameter to daemon conguration and WebUI to configure the SAP multicast address used for sending and receiving source announcements
- added REST API to retrieve the remote sources collected by the daemon (GET /api/browse/sources)
- added Browser tab to the WebUI to visualize info on the available remote sources
- added Info function to sources listed in the Sources tab to visualize the associated SDP file
- extended daemon regression tests to test the SAP Browser
2020-03-06 10:58:07 -08:00
Andrea Bondavalli
f57046a478 fix: use steady_clock instead of high_resolution_clock to avoid being affected by date/time changes 2020-03-02 19:06:21 +01:00
Andrea Bondavalli
4a5f2f8dc0
Fix to the max_sample_per_packet parameter description 2020-02-13 19:18:23 +01:00
Andrea Bondavalli
e1ce27a029 Fixed execution of regression tests on very slow hosts: wait up to 10secs for the daemon to show up at startup.
Consider disabling valgrind in such cases (_MEMORY_CHECK_ define).
2020-02-12 22:05:27 +01:00
Andrea Bondavalli
b3c856e67e Added documentation for get PTP Status REST API 2020-02-12 19:47:19 +01:00
Andrea Bondavalli
d9e167c5ab
Update README.md 2020-02-11 08:10:52 +01:00
Andrea Bondavalli
4c8b225c44 Set of fixes impacting playout delay, max SAP message size and minor enhancements to WebUI. 2020-02-10 21:32:02 +01:00
Andrea Bondavalli
a343123d81 set of small enhancements and fixes 2020-02-07 10:10:15 -08:00
Andrea Bondavalli
c8f437950a Use the ALSA HW plug name instead of the HW device id in all the scripts using the ALSA device 2020-02-06 10:19:15 -08:00
Andrea Bondavalli
5e223ddb53 Initial set of changes to to enable proper compilation ond operations on ARMv7 32bit platform.
- added patch to ALSA RAVENNA/AES67 Driver
- switched to CLANG compiler in order to compile the daemon succesfully
- disabled valgind memory check in daemon regression tests for ARM.
Demo and daemon regression test work properly.
Tests have been executed on the BeagleBone® Black board with ARM Cortex-A8 32-Bit and Ubuntu 18.04 distro
2020-02-05 13:52:01 -08:00
Andrea Bondavalli
a9ad806c12 A single multicast address is used for PTP traffic. 2020-02-03 17:26:50 +01:00
Andrea Bondavalli
0c32e8e698 Added handling of multicast membership for PTP messages.
Limited PTP domain value to the range 0 - 127.
2020-02-02 07:12:36 -08:00
Andrea Bondavalli
67476189d2 Fixes to add and update of source and sink 2020-02-01 15:56:10 +01:00